search

wilk / microjob

A tiny wrapper for turning Node.js worker threads into easy-to-use routines for heavy CPU loads.
https://wilk.github.io/microjob/
MIT License
2.02k stars 47 forks source link

Node 12.5 Deprecation Warning (worker.terminate()) #43

Closed Haidy777 closed 5 years ago

Haidy777 commented 5 years ago

Hello,

I've just started using this great library. Since 12.5. worker.terminate() throws a deprecation Warning, as it returns a Promise now (see https://github.com/nodejs/node/pull/28021).

Correct me if I am wrong, but https://github.com/wilk/microjob/blob/bb031688bac04f957e924fbba90968fa05374866/src/worker-pool.ts#L221 should be the only position where this should be changed?

I'll try to submit a PR to change it.

wilk commented 5 years ago

Thank you!