search

wilk / microjob

A tiny wrapper for turning Node.js worker threads into easy-to-use routines for heavy CPU loads.
https://wilk.github.io/microjob/
MIT License
2.02k stars 47 forks source link

unit tests / CI #5

Closed DanielRuf closed 6 years ago

DanielRuf commented 6 years ago

We should add Travis CI to test every commit and PR of microjob.

wilk commented 6 years ago

Hell yeah! Thank you for opening this issue! I'll put it on the roadmap 💪

motss commented 6 years ago

How about CircleCI?

DanielRuf commented 6 years ago

CircleCI is faster, yes. So far Travis CI is more often used and has a good support and also provides OSX images for testing.

Another additional solution is AppVeyor for Windows builds / testing on Windows images.

motss commented 6 years ago

I use both TravisCI and CircleCI. Tried AppVeyor but it's way too slow to test on multiple Node.js versions. I gave up using that eventually.

DanielRuf commented 6 years ago

I use both TravisCI and CircleCI. Tried AppVeyor but it's way too slow to test on multiple Node.js versions. I gave up using that eventually.

How do you test on Windows then? CircleCI has no Windows builds and Travis CI too. So AppVeyor is currently the only big option for testing commits on Windows.

motss commented 6 years ago

Fun fact is that I code with Windows machine so making assumption that it will work on Windows. For Linux and Mac, I do have Linux and Mac machines plus those CIs to help out.

I'm a Mac user in the daytime but a Windows user during the night.

DanielRuf commented 6 years ago

Fun fact is that I code with Windows machine so making assumption that it will work on Windows. For Linux and Mac, I do have Linux and Mac machines plus those CIs to help out.

But not every project and every contributor ;-)

wilk commented 6 years ago

I've integrated Travis for now: https://travis-ci.org/wilk/microjob If you want to contribute with more tests and feature related to CI/CD, please fill free to open new specific issues and/or PRs 💪