wilkelab / Opfi

A Python package for discovery, annotation, and analysis of gene clusters in genomics or metagenomics data sets.
https://opfi.readthedocs.io/
MIT License
21 stars 5 forks source link

Fix bug that may cause _contains_group to return False prematurely #153

Closed alexismhill3 closed 4 years ago

alexismhill3 commented 4 years ago

While working on an extension to the contains_group rule, I noticed a small bug - basically, if any group of features is found to contain all of the names in feature_names but has gaps or orientations that don't meet the user requirements, the rule will automatically fail. However, the operon may very well an contain a group of Features upstream that meet all requirements. Therefore, all Feature windows should be exhausted before returning False.

This should fix the issue.