wilkelab / Opfi

A Python package for discovery, annotation, and analysis of gene clusters in genomics or metagenomics data sets.
https://opfi.readthedocs.io/
MIT License
21 stars 5 forks source link

Consistent indices #165

Closed jimrybarski closed 3 years ago

jimrybarski commented 3 years ago

While working with the inverted repeat finder I noticed that there were some really tricky off-by-one errors. One source of this turns out to be that the operon coordinates are 0-based (since they derive from Python indices), while feature coordinates are 1-based (since they come from either BLAST or piler-cr). This pull request converts features to 0-based indices when parsing the raw gene_finder output.

While updating some tests I noticed there were many identical copies of a few so I deleted them, and fixed the formatting on a few others. Really this should've been in a separate commit in retrospect.