wilkelab / Opfi

A Python package for discovery, annotation, and analysis of gene clusters in genomics or metagenomics data sets.
https://opfi.readthedocs.io/
MIT License
21 stars 5 forks source link

Allow ignoring of features to persist when serialized #172

Closed jimrybarski closed 3 years ago

jimrybarski commented 3 years ago

Currently we have to re-apply filters each time an operon is deserialized, but this is error-prone as it's easy to forget and the same filters must be applied each time. It would be better to apply them once and then have the ignored status be saved. I think this will be as simple as adding an extra optional field to the Operon.as_str() method and making sure the parser can handle it.

jimrybarski commented 3 years ago

I think it's too risky to do this now as it would probably be backwards-incompatible. We can re-examine it if there's ever a v2.