Closed BrianLang closed 4 years ago
I'm fine with this in principle, but this PR will need a lot of work before it can be merged. Just off the top of my head:
Call the argument byrow
as in matrix()
.
Place the new argument before the deprecated arguments.
Don't use F
, write FALSE
.
The new argument needs to be documented and documentation re-generated.
There needs to be an entry in the changelog (NEWS.md
). Look at the ggplot2 source for how to format contribution by outside contributors.
There needs to be a visual test for the new feature. Visual tests are currently failing, so I need to fix them first. I suggest you develop the code for the visual test but just post it here in a comment rather than adding to the code at this time, so we can discuss.
Thanks for this feedback, I now have done most of these things to the extent that I understand what you want.
byrow
.rows
and cols
.FALSE
instead of F
Minor changes
plot_grid()
now acceptsbyrow
as an argument to place plots by row or by column onto the plot area. (@BrianLang, #162).
test_that("basic plot arranging works"
test:
expect_doppelganger("colwise arranging",
plot_grid(p1, NULL, p2, NULL, p3, NULL, byrow = FALSE) + theme_map()
)
Fix #161