wilkelab / cowplot

cowplot: Streamlined Plot Theme and Plot Annotations for ggplot2
https://wilkelab.org/cowplot/
701 stars 84 forks source link

suggestion to address `get_legend` issue #205 #206

Open jkylearmstrong opened 2 months ago

jkylearmstrong commented 2 months ago

suggestion to address get_legend issue #205

A side effect is that now fails test "get legend" however, noted in comments the test is

"more of a duct tape solution than a reflection of the intended behaviour".

I think for almost all components it would be reasonable to return first nonZero Grubs by default, the option to return all also enables the user to grab all labels that match.

clauswilke commented 2 months ago

See my comment in #205.