wilkelab / ggridges

Ridgeline plots in ggplot2
https://wilkelab.org/ggridges
GNU General Public License v2.0
412 stars 31 forks source link

fix #48 #49

Closed shabbybanks closed 4 years ago

shabbybanks commented 4 years ago

Allow user to pass a scalar quantile in, without it being interpreted as the number of divisions.

codecov-io commented 4 years ago

Codecov Report

Merging #49 into master will increase coverage by 1.41%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   55.62%   57.04%   +1.41%     
==========================================
  Files          13       13              
  Lines         320      284      -36     
==========================================
- Hits          178      162      -16     
+ Misses        142      122      -20
Impacted Files Coverage Δ
R/stats.R 100% <ø> (ø) :arrow_up:
R/scale-cyclical.R 85.71% <0%> (-0.78%) :arrow_down:
R/theme.R 100% <0%> (ø) :arrow_up:
R/scale-.R 0% <0%> (ø) :arrow_up:
R/utils.R 100% <0%> (ø) :arrow_up:
R/geom-density-line.R 0% <0%> (ø) :arrow_up:
R/position.R 0% <0%> (ø) :arrow_up:
R/geomsv.R 0% <0%> (ø) :arrow_up:
R/geoms.R 34.37% <0%> (+0.22%) :arrow_up:
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb2b9b4...7152b74. Read the comment docs.

clauswilke commented 4 years ago

I think this is fine, but could you please provide a few use cases demonstrating your new use as well as the old one where we set quantile equal to an integer value?

clauswilke commented 4 years ago

Thanks!