Closed teunbrand closed 7 months ago
Thanks, this looks rather straightforward. Could you just add a little comment, something like "Legend structure changed with ggplot2 3.5" or similar, so the conditional testing is properly documented for the future? Ideally on both tests.
You got it 👍
This is now on CRAN.
Thank you Claus!
Hi Claus,
It is me again, running down reverse dependency checks. I'm posting this because the prospective ggplot2 3.5.0 would break a test in ggridges.
The change is that a plot now always has guide boxes (though they are zero grobs if empty). Hence, testing for presence/absence of a guide by checking the gtable for the 'guide-box' name no longer works. This PR uses the new
get_guide_data()
to test for a legend's presence or absence.For completion; to test the code changes with the release candidate, you can install it with the code below:
The release of ggplot2 3.5.0 is scheduled for the 12th of February. The progress of the release can be tracked in https://github.com/tidyverse/ggplot2/issues/5588. I hope that this PR might help ggridges get out a fix if necessary.