search

wilkelab / ggtext

Improved text rendering support for ggplot2
https://wilkelab.org/ggtext/
GNU General Public License v2.0
650 stars 37 forks source link

Upcoming change in `ggplot2:::titleGrob()` #101

Closed teunbrand closed 6 months ago

teunbrand commented 1 year ago

Hi Claus and Brenton,

This issue is just a heads up that in the dev version of ggplot2, the titleGrob() has been refactored. In particular, the function in ggtext's R/add-margins.R might have become obsolete. I tried to see if any visual tests had broken, but wasn't able to verify due to a vdiffr version difference. By eye, nothing looks wrong, but it might be not the worst idea to double-check yourselves against ggplot2's dev version at some point. Feel free to close this issue if all is behaving as expected.

clauswilke commented 1 year ago

As far as I can tell (and remember), the code paths in ggtext are entirely independent of titleGrob() in ggplot2. So any changes there should not affect ggtext, unless some very fundamental changes were introduced into how text elements work in themes, and I don't think is the case. So I wouldn't expect any problems, but a check wouldn't hurt.

@bwiernik Are you willing to go through the visual tests and make sure they all look correct with the development version of ggplot2?

bwiernik commented 1 year ago

Sure

teunbrand commented 6 months ago

I tested with the dev version of ggplot2 and all appears to be fine, so I'll go ahead and close this.