search

wilkerlucio / pathom-viz

Visualization tools for Pathom
88 stars 10 forks source link

Broken Queries Lock Up the UI #25

Closed royalaid closed 3 years ago

royalaid commented 3 years ago

Submitting invalid queries, i.e. [{[:curriculum/uuid <snip>]}], causes the UI to lock up

wilkerlucio commented 3 years ago

Hello, I just tried to reproduce, but I can't get the UI to freeze, can you give more details?

royalaid commented 3 years ago

I will try to get a reproduction repo up next week

royalaid commented 3 years ago

Apologies this took so long to investigate. You're correct that the UI doesn't lock with broken queries. It is just that the ability to run a query after attempting to submit a broken query like above, the "Run Query" toggles to a locked state. Another way to if you start a client and connect it to pathom viz, kill that client, then submit a query. Both of these states I have corrected by just issuing a hard refresh of the Electron window. A cancel active query button would also be another potential fix.

wilkerlucio commented 3 years ago

Hello @royalaid , I tried to reproduce it again, but I can't get the UI to lock up, here is a Loom video of me trying to: https://www.loom.com/share/6d882db17c2b4bf9a0b5bbd9c52cd566

If you have a way to reproduce please let me know, closing it for now.