Crash on viewing request

[nivekuil]

pathom viz crash when I try to view a request, version 2021.4.22:

Listening to ipc renderer events
shared.js:166 Error: Cannot compare :date to 1
    at $APP.cljs.core.Keyword.cljs$core$IComparable$_compare$arity$2 (shared.js:4619)
    at Object.$APP.cljs.core._compare (shared.js:3103)
    at $APP.cljs.core.compare (shared.js:3344)
    at shared.js:4329
    at Object.$APP.cljs.core.tree_map_add (shared.js:4329)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$IAssociative$_assoc$arity$3 (shared.js:4351)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$ICollection$_conj$arity$2 (shared.js:4354)
    at $APP.cljs.core._conj (shared.js:3007)
    at Function.$APP.cljs.core.iter_reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3359)
    at Function.$APP.cljs.core.reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3364)
shared.js:8148 INFO [com.fulcrologic.fulcro.rendering.multiple-roots-renderer:152] - Optimized render failed. Falling back to root render.
shared.js:166 Error: Cannot compare :date to 1
    at $APP.cljs.core.Keyword.cljs$core$IComparable$_compare$arity$2 (shared.js:4619)
    at Object.$APP.cljs.core._compare (shared.js:3103)
    at $APP.cljs.core.compare (shared.js:3344)
    at shared.js:4329
    at Object.$APP.cljs.core.tree_map_add (shared.js:4329)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$IAssociative$_assoc$arity$3 (shared.js:4351)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$ICollection$_conj$arity$2 (shared.js:4354)
    at $APP.cljs.core._conj (shared.js:3007)
    at Function.$APP.cljs.core.iter_reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3359)
    at Function.$APP.cljs.core.reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3364)
shared.js:25 Uncaught Error: Cannot compare :date to 1
    at $APP.cljs.core.Keyword.cljs$core$IComparable$_compare$arity$2 (shared.js:4619)
    at Object.$APP.cljs.core._compare (shared.js:3103)
    at $APP.cljs.core.compare (shared.js:3344)
    at shared.js:4329
    at Object.$APP.cljs.core.tree_map_add (shared.js:4329)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$IAssociative$_assoc$arity$3 (shared.js:4351)
    at $APP.cljs.core.PersistentTreeMap.cljs$core$ICollection$_conj$arity$2 (shared.js:4354)
    at $APP.cljs.core._conj (shared.js:3007)
    at Function.$APP.cljs.core.iter_reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3359)
    at Function.$APP.cljs.core.reduce.cljs$core$IFn$_invoke$arity$3 (shared.js:3364)

works on most requests, not sure what's different about that one. the tick tagged literal breaking it? do I need to add a transit handler somewhere

return value is [{0 0, :date #time/date "2021-05-05", 7 0, 20 0, 1 0, 4 0, 15 4.433987204485146, 21 0, 13 0, 22 0, 6 0, 17 0, 3 0, 12 0, 2 0, 23 0, 19 0, 11 0, 9 0, 5 0, 14 0, 16 0, 10 0, 18 0, 8 0}]

[wilkerlucio]

Hello @nivekuil, I just tried to reproduce your problem, but I wasn't able to, in my test setup I made an environment returning the same data as yours, but on my end, it worked.

Which Pathom version are you using? Can you provide a reproduction example that triggers the failure?

[wilkerlucio]

Oh, I just notice the fix was in the code, but not released, I'm doing some changes and I plan to cut a new release tonight. So you can try it out.

[wilkerlucio]

Fixed 9aa646d2208f9a5818adce0354d15cd8fa21480b

[wilkerlucio]

Please try on 2021.05.11, it should be fixed there.

[nivekuil]

It works! thanks :)