search

wilkinsona / project-generator

3 stars 4 forks source link

BuildGradleFileContributor cannot generate Gradle 3 compliant builds #25

Closed snicoll closed 5 years ago

snicoll commented 5 years ago

We still need to support Gradle 3 and compile-scoped dependencies can't use implementation. We probably a notion of "generation" for the writer.

Arguably, that code should also be moved to the base module given the language writers are located there.

wilkinsona commented 5 years ago

The implementation configuration was introduced in Gradle 3.4. We currently use Gradle 3.5 for projects that need Gradle 3 (use Boot 1.5). Isn't that sufficient? All of the integration tests that use Gradle and Boot 1.5 pass at the moment.

snicoll commented 5 years ago

I reported this as tests in the main projects were failing. We have an issue to deprecate "old stuff" (pre 1.5) so perhaps I should get going and just remove the support there as well?

wilkinsona commented 5 years ago

That would be my preference. We'd only need to support versions of Gradle prior to 3.4 if we also wanted to support version of Boot prior to 1.5 and I don't think we should do that.

snicoll commented 5 years ago

Roger that. Thanks for the feedback.