search

wilkinsona / project-generator

3 stars 4 forks source link

Improve .gitignore generation #72

Closed snicoll closed 5 years ago

snicoll commented 5 years ago

There are differences in the way the .gitignore file is generated because the new API dumps a static file at the moment.

I am not super keen to introduce an API for that but perhaps we could use a template since we're doing this for the help document already?

snicoll commented 5 years ago

It's a bit harder than I naively thought. The production code has an assumption about maven and gradle that we don't make with the new API. So adding a template with those notions is not coherent with the new API.

What we have is much better actually. @wilkinsona I wonder if you could review https://github.com/spring-io/initializr/pull/711 in such a way that both outputs are harmonized. This will help us in preparation for merging this work.