search

wilkinsona / project-generator

3 stars 4 forks source link

Provide caching of resource resolution #75

Closed snicoll closed 5 years ago

snicoll commented 5 years ago

Certain contributors read the same file over and over from the classpath, it would be nice if we would cache them.

I've hacked something in https://github.com/wilkinsona/project-generator/commit/d9ec95e0dafbeb7239687a40e56f3dff4aff0743 but this draft definitely needs to be reviewed and improved.

Ping @mbhave, @wilkinsona

wilkinsona commented 5 years ago

I'd rather not add caching unless we're sure that it's needed. The same file may be read over and over, but if that's not prohibitively slow, I'd prefer to keep things simple. Do you have some numbers that show that the current implementation is too slow?

snicoll commented 5 years ago

No, I don't have any performance numbers. I agree we can let it go for now.