search

wilkinsona / project-generator

3 stars 4 forks source link

Fix metrics handling #86

Closed snicoll closed 5 years ago

snicoll commented 5 years ago

Now that we've stopped resolving ProjectRequest (as it should be) part of the request is no longer in a proper state (especially when the request has succeeded).

When the request is successful, no dependencies have been resolved, so this call returns an empty list.

I guess I was wrong when I thought keeping only the request was enough. I am afraid we won't have much of a choice to add a dependency between "web" and "actuator" as the event is likely to move there (as is event management at the moment). That should have happened in any case as we need a new home for Agent.

snicoll commented 5 years ago

@mbhave looks like we're good there now, right?

mbhave commented 5 years ago

yup, I'll close it.