search

wilko339 / PicoGH

Grasshopper wrapper for the ShapeKernel / PicoGK kernel.
Apache License 2.0
6 stars 0 forks source link

ApplyModulation component does not behave correctly. #11

Closed wilko339 closed 7 months ago

wilko339 commented 7 months ago

When using the "ApplyModulation" to modulate an IModulate, instead of creating a copy and then modulating that, the original object is modulated. This means that modulations propagate backwards through the script and will actually change the base object. This is bad, because if other components share access to the base object, they will be accessing a modulated version.

Since multiple modulations can be applied to the same base object, they will all modulate it in their own way...

wilko339 commented 7 months ago

Required the implementation of a deep copy method for modulateable shapes.