search

wilkox / treemapify

🌳 Draw treemaps in ggplot2
http://wilkox.org/treemapify
213 stars 18 forks source link

Make treemapify compatible with plotly r package #40

Open fernandovmacedo opened 4 years ago

fernandovmacedo commented 4 years ago

Adding treemapify is already a plotly issue, but I think it will take a long time. So also adding here to see if the author is willing to help there.

wilkox commented 4 years ago

@fernandovmacedo I'd be happy to help, but I'm not really familiar with plotly – what would be required at my end to make treemapify plotly-compatible?

cpsievert commented 2 years ago

Hi @fernandovmacedo, @moutikabdessabour is looking into a converter here https://github.com/plotly/plotly.R/pull/2051

As I pointed out here https://github.com/plotly/plotly.R/pull/2051#discussion_r741352441, some of the implementation borrows heavily from {treemapify}'s code, and I'd like to avoid any potential GPL vs MIT licensing issues. Would you be willing to either release {treemapify} as MIT and/or sign a contributor agreement? We would, of course, also list you as an author in plotly's DESCRIPTION if you'd like.

wilkox commented 2 years ago

@cpsievert I'd be happy to sign a contributor agreement if that helps. Bob Rudis (@hrbrmstr) is also a listed author of treemapify and there are three other contributors to the package, so I assume at least Bob would have to sign too.

For what it's worth, the only section of the pull request that strikes me as being lifted from treemapify is lines 706–713 of R/layers2traces.R, which probably deserve to be refactored anyway.

hrbrmstr commented 2 years ago

I can def sign as well.

On Mon, Nov 15, 2021 at 01:27 David Wilkins @.***> wrote:

@cpsievert https://github.com/cpsievert I'd be happy to sign a contributor agreement if that helps. Bob Rudis @.*** https://github.com/hrbrmstr) is also a listed author of treemapify and there are three other contributors to the package, so I assume at least Bob would have to sign too.

For what it's worth, the only section of the pull request https://github.com/plotly/plotly.R/pull/2051/files that strikes me as being lifted from treemapify is lines 706–713 of R/layers2traces.R, which probably deserve to be refactored anyway.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wilkox/treemapify/issues/40#issuecomment-968577272, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAD4PNX4HN34JDSEC5GKGSDUMCR3ZANCNFSM4NO2CFCQ .