search

will-lumley / FaviconFinder

A small swift library for iOS & macOS to detect favicons used by a website.
MIT License
161 stars 33 forks source link

Update SwiftLint #79

Closed knightbenax closed 3 months ago

will-lumley commented 3 months ago

Hey knightbenax, Thanks for setting up this PR, this is great. The failed unit tests seem to be unrelated to your changes, so I will be looking into them tonight.

will-lumley commented 3 months ago

Hey @knightbenax - I just realised that the package you're replacing the official SwiftLint repository by is from an unknown source of SimplyDanny. Can you explain why this is a better option?

knightbenax commented 3 months ago

@will-lumley that's the source that is on the official SwiftLint repository - https://github.com/realm/SwiftLint

will-lumley commented 3 months ago

Hi @knightbenax - apologies but I think I'm confused. In your PR you have changed the repository from https://github.com/realm/SwiftLint to https://github.com/SimplyDanny/SwiftLintPlugins. This is not the offical SwiftLint repository.

Screenshot 2024-07-30 at 10 02 33 PM
knightbenax commented 3 months ago

@will-lumley do check the ReadME from https://github.com/realm/SwiftLint it has changed the SPM url to https://github.com/SimplyDanny/SwiftLintPlugins now

will-lumley commented 3 months ago

@knightbenax Great catch, thanks for walking me through that. Approved.

knightbenax commented 3 months ago

@will-lumley anytime