search

will-rowe / hulk

Histosketching Using Little Kmers
MIT License
55 stars 4 forks source link

"smash" fails if -d does not end in "/" #8

Closed kyclark closed 5 years ago

kyclark commented 5 years ago

In "src/histosketch/histosketch.go" the glob pattern is created like this:

307 fp := sketchDir + "*.sketch"

But this fails if "sketchDir" does not end in "/". I'm not a Go programmer, but maybe something like https://golang.org/pkg/path/filepath/#example_Join could fix this? Or just append the appropriate directory delimiter ("/", "\") if one is not there?

will-rowe commented 5 years ago

This has been bothering me too, thanks for giving me the nudge to fix it

will-rowe commented 5 years ago

Fixed in 2b878c9afc3f9376266bcb80c77fc0b842a6a0f7