search

will-stone / browserosaurus

🦖 The browser prompter for macOS
https://browserosaurus.com
GNU General Public License v3.0
1.72k stars 161 forks source link

Ventura virtual desktop compatibility #582

Closed faebe closed 1 year ago

faebe commented 2 years ago

Is there an existing issue for this?

Current Behaviour

Since MacOS Ventura when the app was previously opened on another virtual desktop and a link is clicked on a different virtual desktop the desktop will switch to that previous virtual desktop but the browser selector UI will not show / disappear immediately. Quitting and restarting the app solves the issue temporarily every time.

Expected Behaviour

The browser selector UI should appear on the current virtual desktop in the foreground, no matter what virtual desktop it was opened on previously.

Steps To Reproduce

  1. Install MacOS Ventura
  2. Open a link on a virtual desktop using Browserosaurus
  3. Go to another virtual desktop
  4. Open another link using Browserosaurus

Browserosaurus version

19.1.0

macOS version

13.0

CPU Architecture

ARM

Anything else?

No response

will-stone commented 2 years ago

Hi @faebe Thank you for reporting. I don't currently have time to look into this issue, and I don't use virtual desktops so it's not a priority for me. I'd gladly review a pull request if you'd like to submit one 🙂

roastedduk commented 2 years ago

Can confirm I have this issue too with latest stable Ventura release.

will-stone commented 2 years ago

Thanks @roastedduk. Happy to review a PR if you find the culprit 😄

will-stone commented 2 years ago

Hi @faebe @roastedduk Could you please do a screen recording of the issue you're facing as it seems to be working okay when I try it. Here's my setup:

roastedduk commented 2 years ago

Hey sorry for the late reply. I can't seem to reproduce the issue anymore after restarting. Not sure what happened but it's working fine now.

roastedduk commented 2 years ago

https://user-images.githubusercontent.com/105736696/200748895-af5e13fe-c297-4275-b312-380da778cf8c.mp4

Nvm, encountered the bug again, B 19.1.0, Ventura 13.0. Hope this helps!

y-mx-b commented 1 year ago

I've seen this bug pop up now and again since either Big Sur or Catalina. I'm not entirely sure why this happens, and it's not easily reproducible. Quitting and reopening the app tends to fix it though.

flacial commented 1 year ago

I tried to reproduce it in the development app (19.2.0), but it doesn't occur at all. However, it seems to be related to electron workspace API

@roastedduk @faebe may you share how to reproduce it? It'll help in finding the culprit

roastedduk commented 1 year ago

I tried to reproduce it in the development app (19.2.0), but it doesn't occur at all. However, it seems to be related to electron workspace API

@roastedduk @faebe may you share how to reproduce it? It'll help in finding the culprit

It's still happening with 19.2.0 for me, but same as @y-mx-b it happens randomly and not easily reproducible so I'm not sure too. But when it happens it will keep bugging until I restart the app.

joelmgallant commented 1 year ago

Agreed - I see this pretty frequently. First; love this software, it's an absolute gem - and thank you for it!

Generally I have a setup with:

The behaviour I observe often has these characteristics:

My original theory: external monitor / docking & undocking - it would tend to happen after detaching from a larger monitor space, laptop going to sleep, re-opening later.

This doesn't seem like the whole story though - I just experienced this on resume from sleep without attaching a monitor in between.

Killing the app processes & restarting them resolves the issue.

I'm also of the opinion this is probably Electron-related -- if I manage to debug I'll happily PR it!

porcherie commented 1 year ago

For me it is easily reproducible, I made a video recording where you can see how it happens https://www.loom.com/share/768eb91aa8a0463a9a86d92e4b6a355c

I'm on Ventura 13.0.1 on a MacBook Pro 16 M1

iljamm commented 1 year ago

Getting exact same issue as @porcherie

image

riotrah commented 1 year ago

I think this is (probably) a duplicate of #136 #356 #595

kirkbig commented 1 year ago

i have seen this issue a lot as well. i love this product, but since venture, i've had to load most of my apps into a single virtual desktop to get it working reliably.

will-stone commented 1 year ago

Let’s close this in favour of #595

kirkbig commented 1 year ago

Let’s close this in favour of https://github.com/will-stone/browserosaurus/issues/595

fwiw, the apps that i've been having difficulty with are not full-screen, though the behavior described in #595 does seem likely related.