Update for Crystal 0.36 compatibility

will / crystal-pg

a postgres driver for crystal

BSD 3-Clause "New" or "Revised" License

462 stars 77 forks source link

Update for Crystal 0.36 compatibility #226

Closed bcardiff closed 3 years ago

bcardiff commented 3 years ago

This PR makes the spec build on Crystal 0.36 without warnings. The changes are backward compatibly with 0.35.

Another optional change is to declare this shard compatible with 1.0.0-x which should be almost 0.36. Is not mandatory and --ignore-crystal-version can be used otherwise.

will commented 3 years ago

Also semi-related* please take a look at https://github.com/crystal-lang/crystal/pull/8005 in case that's fallen off your radar. It would be nice to get that in so that this driver could support scram with channel binding.

* in that it is for this project

bcardiff commented 3 years ago

There is little need for a release right now. The latest release works fine for 0.36. But a patch release would not hurt.

To get up to date with version things I can point to https://crystal-lang.org/2020/08/20/preparing-our-shards-for-crystal-1.0.html

Sorry crystal-lang/crystal#8005 was totally out my radar until now. I'll try to give feedback.