will / crystal-pg

a postgres driver for crystal
BSD 3-Clause "New" or "Revised" License
462 stars 77 forks source link

Allow use of PG environment variables along with .pgpass files #264

Closed wishdev closed 1 year ago

will commented 1 year ago

Thanks @wishdev! Could you though make one PR for adding the env vars and another for the pgpass? The reason being I think testing the env vars might be a little too much set up for CI, but the pgpass there could be some tests for.

Maybe if the pgpass was split up a bit so the parsing could at least be tested, it'd help make sure it doesn't silently break in the future

wishdev commented 1 year ago

@will I just pushed tests for all pieces - I did not break it up because I think testing everything covered your concerns here (if I read your comment correctly). I'm more than happy to break it up if that is still necessary

will commented 1 year ago

Thanks!