search

will133 / vim-dirdiff

Vim plugin to diff two directories
335 stars 59 forks source link

support ignoreFileNameCase #17

Closed happycherry closed 5 years ago

happycherry commented 6 years ago

For windows platform, if there is a file called a.txt while another file called A.txt, it will consider these two files are different and will not compare these two. So to solve these issue and an option called FileNameIgnoreCase to mitigate.

happycherry commented 6 years ago

@will133, could you help to take a look?

will133 commented 6 years ago

I think this looks good but can you change the variable to DirDiffFileNameIgnoreCase? It'll be more consistent that way.

will133 commented 6 years ago

Actually, since the diff argument is --ignore-file-name-case, it should probably be DirDiffIgnoreFileNameCase.

happycherry commented 6 years ago

@will133 ,sorry for delayed reply, really thanks for your remind. i have updated.

happycherry commented 5 years ago

@will133 , could you help to review and checkin?