0-Gixty-0
commented
6 months ago Tagging Alexander (@DuchessMuhr) since we copied his implementation for connecting the search combo boxes to parent component for automatic update. Implementation was copied from changes to the ParentSearchComboBox component. We recommend that issue #29 and issue #24 should be merged first in order to check for possible merge conflicts and resolutions.
Other points of note:
- CSS implementation commit has not yet been pushed since it is still local on Lucas machine. This should be added before reviewers merge the branch into main
- Known issue/missing implementation is that the reset selection option does not clear the combo box selectors. This combined with changing the selector does not remove previously rendered statistics and changes button back to generate state. It is slightly unintuitive, however I found that this issue is small enough that it can be solved later.
- Test file testStatisticGeneration.test.ts is not entirely implemented correctly. Ideally the needed method should be imported or activated through the component StatisticContainer with test state. I could not find a good solution for this without just adding everything into the file that I needed. This should also be fixed later in my opinion
What
Created statistical generation based on four forms of selection:
Note: If no event is found an error message is displayed informing the user
How
User story was completed through creating a new page statistics with selectors for location and event type. Upon clicking the generate button a table with rows described in the above what heading is displayed. Statistic generation rows update automatically once the props passed to the Table.tsx component updates which occurs only once the user has clicked the generate button.
Why
In order to inform users on crime statistics for locations and event types in a clear and concise way not achieved on the original police website for events.