Closed myarete closed 5 years ago
Merging #43 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #43 +/- ##
======================================
Coverage 62.4% 62.4%
======================================
Files 10 10
Lines 274 274
Branches 63 63
======================================
Hits 171 171
Misses 81 81
Partials 22 22
I added the types originally and I'm not sure why I didn't do what you're suggesting either. +1.
:tada: This PR is included in version 2.4.1 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Woop woop!
I'm not sure if there's any particular reason that the type
string
was being used overSquare
||Piece
, but it causes clashing with the types fromchess.js
. I personally feel that the types fromchess.js
should be used as much as possible since people will be using these libs together. Especially given that the typeSquare
in both typedefs is identical.Their type for
Piece
is slightly different, but for my use case, changing toSquare
instead ofstring
fixes my issues with the callbacks such asonDrop
:)Before:![Before the fix](https://user-images.githubusercontent.com/12105346/63269862-968b4480-c25c-11e9-8970-51287a08d2f7.png)
After:![After the fix](https://user-images.githubusercontent.com/12105346/63269867-98ed9e80-c25c-11e9-9980-04b163288b79.png)