Closed silverweed closed 4 years ago
src/Labels.hs, line 3 at r1 (raw file):
{-# LANGUAGE LambdaCase #-} {-# LANGUAGE OverloadedStrings #-}
This pragmas are included in
.cabal
file already.
src/Labels.hs, line 1 at r1 (raw file): Is there any unused functions in this module?
src/Labels.hs, line 23 at r1 (raw file):
Let use meta <- T.decodeUtf8 <$> BS.readFile file
where T and BS is from
import qualified Data.ByteString as BS
import qualified Data.Text as T
because of https://www.snoyman.com/blog/2016/12/beware-of-readfile
src/Labels.hs, line 1 at r1 (raw file):
Is there any unused functions in this module?
https://guide.aelve.com/haskell/how-to-make-code-warning-free-qkostv6r#item-ogh2yr1a
Thanks for the reviews and explanations, I'll push the fixes as soon as I have time :)
Thank you very much for contributing!
Addresses #77.
I removed the dependency from Aeson and transformed
stuff.json
into TOML format. In doing so I added thepath
key (which was the dictionary key before) and turned the Json dictionary itself into an array namedtitles
.From:
to (conceptually):
I (manually) tested the change and it seems to work fine.
This change is