Bug fixes and validation error fixes

0xdabbad00 commented 5 years ago

This fixes #1 and begins fixing the validation errors of #2. It also bypasses checking the s3control service in order to avoid the problem in #3 until a better fix can be found for that. This feels like a lot of hacks for the validation error fixes, but the alternative of automatically generating these seems really complex. Currently, all IAM functions can run now. There are still validation issues with cloudformation, elasticbeanstalk, elbv2, ses, and sts. Those total about 100 more validation errors that I'll add similar code changes for.

willbengtson commented 5 years ago

Thanks @0xdabbad00! Been on the backlog, appreciate your help in fixing these!

0xdabbad00 commented 5 years ago

There are a few server side validation checks in elbv2 that I can't figure out how to bypass that are all related to ARN's. These show up as:

error: An error occurred (ValidationError) when calling the DeleteListener operation: 'arn:aws:iam::123456789012:user/test' must be in ARN format

I tried all sorts of possible ARNs, including ones directly from the docs on elbv2. Nothing worked. I need to review the network requests of some legit requests I guess from the CLI and copy them in.

The ARN format issues appear for the following:

elbv2.delete_listener
elbv2.delete_load_balancer
elbv2.delete_rule
elbv2.delete_target_group
elbv2.modify_listener
elbv2.modify_rule
elbv2.remove_tags
elbv2.set_ip_address_type
elbv2.set_security_groups
elbv2.set_subnets

0xdabbad00 commented 5 years ago

This PR should be closed as the path I was going down is not ideal (ie. manually trying to make special cases for what ended up being every function). There are some good fixes in the first and second commit, so feel free to merge those in manually or something somehow, or I can create another PR for those.

0xdabbad00 commented 5 years ago

Closing this in favor of #5

willbengtson / trailblazer-aws

Bug fixes and validation error fixes #4