search

willdale / SwiftUICharts

A charts / plotting library for SwiftUI. Works on macOS, iOS, watchOS, and tvOS and has accessibility features built in.
MIT License
843 stars 105 forks source link

Fixes the HorizontalColourBar to show the roundedness correctly #179

Closed sai-manoj-kumar closed 2 years ago

sai-manoj-kumar commented 2 years ago

Fix for the Issue #178.

Before Fix After Fix
before fix the corner radius after fix the corner radius is correct
sai-manoj-kumar commented 2 years ago

@willdale Can you please review this PR?

sai-manoj-kumar commented 2 years ago

@willdale Addressed your comments. Can you please review it again?

willdale commented 2 years ago

Failing build on iOS 14 and tvOS 14: Cannot convert value of type 'Double' to expected argument type 'CGFloat'

willdale commented 2 years ago

The chart no longer animates on appear.

sai-manoj-kumar commented 2 years ago

@willdale, I have fixed the animation issue and build error. Please review the changes.

willdale commented 2 years ago

I'm going to decline this PR. The implementation is too specific to one chart type. I've got an implementation from V3 which I will back port for all bar chart types.

Thanks, Will