willdale / SwiftUICharts

A charts / plotting library for SwiftUI. Works on macOS, iOS, watchOS, and tvOS and has accessibility features built in.
MIT License
843 stars 105 forks source link

X labels height is miscalculated #185

Closed AvdLee closed 2 years ago

AvdLee commented 2 years ago

Looking at this code:

https://github.com/willdale/SwiftUICharts/blob/7b50b531c36f30d41b5208f7dbc63df245936849/Sources/SwiftUICharts/SharedLineAndBar/Views/RotatedText.swift#L58

Shouldn't we add the height to the xAxisLabelHeights instead of the width?

willdale commented 2 years ago

Hey @AvdLee, you beat me to my mornings' task.

AvdLee commented 2 years ago

That was fast, thanks a lot! Closing this one accordingly.