search

willdebras / ctar

R package to get data from the CTA train tracker API
MIT License
8 stars 4 forks source link

change use of 'raw' as variable name #10

Open jameslamb opened 5 years ago

jameslamb commented 5 years ago

I see this pattern in multiple places in the code:

url <- paste0(something, something_else)
raw <- httr::GET(url)

...

In general, I think it's a good idea to avoid using variable names that conflict with other names in the package environment, especially those in packages like base that are loaded by default. I have seen it lead to strange situations, especially when combined with libraries like ggplot2 or data.table that use non-standard evaluation.

I think you should change all those raw to raw_response or something like that.

willdebras commented 5 years ago

Hey James. Definitely agree. I'll clean up these variable/parameter names. Thanks for the suggestion!