search

willdurand / BazingaHateoasBundle

Integration of the Hateoas library into Symfony.
MIT License
294 stars 59 forks source link

Allow jms serializer bundle 2.0 and removed some deprecations #64

Closed goetas closed 7 years ago

goetas commented 7 years ago

JMS Serializer Bundle

Today I have released the JMS serializer bundle 2.0. The new version is almost 100% backward compatible with the 1.x, so no changes are required from the user point of view. The changes are mainly about changing some defaults to optimize performance and DX, here a full list

Build and symfony compatibility changes

On the way of integrating the new bundle, I have discovered some problems when the symfony 3.0 support was added (https://github.com/willdurand/BazingaHateoasBundle/commit/51c06604ebd11fe197a48f39ed9f6d31c898ad6c was a bit too optimistic and no builds on travis were updated)

Details

Changes in this pr:

https://github.com/willdurand/BazingaHateoasBundle/pull/64/commits/c7628b85ba4a805b41fe55762026158875716895 allows jms serializer bundle 2.0 + changes the deprecated service alias https://github.com/willdurand/BazingaHateoasBundle/pull/64/commits/d21056e20cb8ba595e8557511472296c4e3df63b removes the deprecated "set service container call" https://github.com/willdurand/BazingaHateoasBundle/pull/64/commits/993922fddce443889a4f211017c611837619706c runs builds into travis containers, adds tests for latest symfony releases and adds tests for low library versions https://github.com/willdurand/BazingaHateoasBundle/pull/64/commits/4e458023a50ec5c0da5ee47a1129036272db6476 HHVM builds were green before... travis was misconfigured https://github.com/willdurand/BazingaHateoasBundle/pull/64/commits/7f01b236acfb7bbeb8a3af437737ed48772e8118 symfony 2.2 was not supported and tests were failing when running it and min deps (dependency injection 2.8 was used)

hhvm builds are green too now

goetas commented 7 years ago

ready to be reviewed :)

willdurand commented 7 years ago

Looks good to me. Would it make sense to release a major release to align with the JMS bundle?

goetas commented 7 years ago

IMO is not necessary a new major release... anyway the changes are fully backward compatible from the hateoas point of view.

Keeping the current release number, will keep compatibility with possible other bundles that might depend on BazingaHateoasBundle.