search

willdurand / BazingaHateoasBundle

Integration of the Hateoas library into Symfony.
MIT License
294 stars 59 forks source link

add option to disable twig extension registered by bundle #75

Closed ahilles107 closed 6 years ago

ahilles107 commented 6 years ago

Hey guys, is this wrong approach?

adrienbrault commented 6 years ago

This looks fine, but what about making the twig extension private ?

ahilles107 commented 6 years ago

in Symfony 4.0 it will be private by default (as it't not set to public). But changing it now would be BC break for some users. This is why i set it in configuration to be enabled by default.

ahilles107 commented 6 years ago

@adrienbrault - can we merge it?

adrienbrault commented 6 years ago

👍

willdurand commented 6 years ago

thanks!