search

willdurand / BazingaJsTranslationBundle

A pretty nice way to expose your Symfony translation messages to your client applications.
MIT License
572 stars 178 forks source link

When domain is not defined, get_message find translations in intl-icu format but don't format it correctly #315

Open spras opened 3 years ago

spras commented 3 years ago

Given the following translations file:

# translations/messages+intl-icu.en.yaml hello_name: Hello {name}!

When domain is not defined, get_message find the translation in intl-icu format, but it don't format it correctly.

Translator.trans('hello_name', { name: 'John' })

give

Hello {name}!

it should give

Hello John!

spras commented 3 years ago

314 fix it

aheidelberg commented 3 years ago

I encountered the same issue, is this going to be merged?