search

willdurand / BazingaJsTranslationBundle

A pretty nice way to expose your Symfony translation messages to your client applications.
MIT License
572 stars 178 forks source link

Load translations from Translator's message catalogue #346

Open drola opened 8 months ago

drola commented 8 months ago

Load translations from Translator's message catalogue

Context:

Existing implementation of BazingaJsTranslationBundle re-implements loading messages from files on disk. However, this implementation is not 1-to-1 compatible with message loading in Symfony's translator component. Thus some translations are not visible to BazingaJsTranslationBundle.

For example, LexikTranslationBundle stores messages in a DB,

This PR re-implements message discovery, such that it relies on Symfony\Component\Translation\Translator.

This change was suggested in #277.

Backwards Compatibility:

monteiro commented 6 months ago

Hi @drola , can you rebase it? Thanks for your first contribution!

drola commented 6 months ago

Hi @drola , can you rebase it? Thanks for your first contribution!

Hey, @monteiro! It's rebased now.

Happy to help, I use this bundle in several projects.

betoobe6 commented 4 months ago

Hi there,

I'm glad someone solved this ! Do you know when it will be available in the release ? We are using LexikTranslationBundle and would love to have only one translation WF !

Thanks