willdurand / Negotiation

Content Negotiation tools for PHP.
https://williamdurand.fr/Negotiation/
MIT License
1.41k stars 62 forks source link

Add missed fallback to generic language (in `LanguageNegotiator`) #113

Closed rtm-ctrlz closed 2 years ago

rtm-ctrlz commented 3 years ago

Same fix as #65 but for current version

Seb33300 commented 3 years ago

@rtm-ctrlz is it a fix for https://github.com/willdurand/Negotiation/issues/102?

rtm-ctrlz commented 3 years ago

@Seb33300 yes, this PR should fix it

Seb33300 commented 3 years ago

Ping @willdurand, if you could merge this PR it could be very helpfull since branch 2.x doesn't support PHP 8 so we cannot rely on it anymore.

BTW, this will fix all of the language related issues: #103, #102, #80

Thank you

willdurand commented 2 years ago

Super sorry for not having merged this patch earlier.. I'll release a new version soon.

willdurand commented 2 years ago

https://github.com/willdurand/Negotiation/releases/tag/3.1.0