willdurand / Negotiation

Content Negotiation tools for PHP.
https://williamdurand.fr/Negotiation/
MIT License
1.41k stars 62 forks source link

Generic language negotiation is missing since 2.0 #76

Closed ruudk closed 6 years ago

ruudk commented 8 years ago

I don't know if this is an mistake or not but this merged PR https://github.com/willdurand/Negotiation/pull/65 is missing in 2.0.

$acceptLanguageHeader = 'fr-FR, en-US;q=0.8';
$priorities           = array('fr');
// should return 'fr'
willdurand commented 8 years ago

Hi! so this is what you tweeted me the other day, right? It has not been backported I'd say.

ruudk commented 8 years ago

Yep I tweet about that.

Would it be easy to have this back in? Because it has been fully rewritten.

hirbod commented 6 years ago

will this ever get fixed?

willdurand commented 6 years ago

@Hirbod this should be fixed by https://github.com/willdurand/Negotiation/pull/96