search

willdurand / Negotiation

Content Negotiation tools for PHP.
https://williamdurand.fr/Negotiation/
MIT License
1.41k stars 62 forks source link

Implement getOrderedElements() #90

Closed akrabat closed 7 years ago

akrabat commented 7 years ago

This method retrieves the elements of the given Accept/Accept-* header as an array ordered with the most preferred first.

Fixes #75

akrabat commented 7 years ago

Hmm... Seems that PHP 5 and PHP 7 order differently when equal…

willdurand commented 7 years ago

😞

akrabat commented 7 years ago

Reading the logs, I think the AppVeyor build has failed due to an installation issue rather than anything to do with this change.

akrabat commented 7 years ago

This also merges cleanly to the 2.x branch.

willdurand commented 7 years ago

Yep, I don't get why it fails actually. Investigating right now...

willdurand commented 7 years ago

Hi @akrabat, could you please rebase your branch so that we can ensure it passes on Appveyor too? I fixed the build (in theory).

akrabat commented 7 years ago

Rebased

akrabat commented 7 years ago

@willdurand There we go! Thanks for fixing Appveyor 👍

willdurand commented 7 years ago

Thank you!