willdurand / Negotiation

Content Negotiation tools for PHP.
https://williamdurand.fr/Negotiation/
MIT License
1.41k stars 62 forks source link

Regression in recent releases #93

Closed willdurand closed 7 years ago

willdurand commented 7 years ago

Copy/paste from #92:

Hi @willdurand, @weierophinney! This PR and the new release (2.3) breaks our test suite on api-platform/core. See https://travis-ci.org/api-platform/core/jobs/228775063 for example.

I have this accept header: application/hal+json. My priorities are:

[0] => "application/ld+json" [1] => "application/hal+json" [2] => "application/xml" [3] => "text/xml" [4] => "application/json" [5] => "text/html" Then, the AbstractNegotiator::getBest() method now returns application/ld+json instead of application/hal+json before.

It looks like something is not working properly here, nop? Thanks.

(Ping @dunglas)

weierophinney commented 7 years ago

I'm AFK until Monday, but will look at it first thing then; I suspect I know what's happening and how to resolve it.

On May 4, 2017 11:27 AM, "William Durand" notifications@github.com wrote:

Copy/paste from #92 https://github.com/willdurand/Negotiation/pull/92:

Hi @willdurand https://github.com/willdurand, @weierophinney https://github.com/weierophinney! This PR and the new release (2.3) breaks our test suite on api-platform/core. See https://travis-ci.org/api- platform/core/jobs/228775063 for example.

I have this accept header: application/hal+json. My priorities are:

[0] => "application/ld+json" [1] => "application/hal+json" [2] => "application/xml" [3] => "text/xml" [4] => "application/json" [5] => "text/html" Then, the AbstractNegotiator::getBest() method now returns application/ld+json instead of application/hal+json before.

It looks like something is not working properly here, nop? Thanks.

(Ping @dunglas https://github.com/dunglas)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/willdurand/Negotiation/issues/93, or mute the thread https://github.com/notifications/unsubscribe-auth/AABlV02sS1PmtrCFlLgDo_Ft2TlU3Zq2ks5r2gpjgaJpZM4NQ-q3 .