Closed foxsouns closed 3 years ago
You'll need to remove 333e92f from this branch. Also, update the readme for both this and the other PM you added.
oh, whoops! yeah, ill get on that.
Huh, neat. I can request review from myself.
@willeccles that should do it :>
@willeccles should be up to standard now; should i reorder the script to be in alphabetical order as well?
@willeccles should be up to standard now; should i reorder the script to be in alphabetical order as well?
No, we have them in the order they are for some reason that I can't remember. The order within the script isn't really important so long as the order of the cases at the bottom and the order of the respective functions matches.
I'm fairly certain that you haven't read CONTRIBUTING.md - being that this uses ls, and you suggested both cat
and grep
in my PR.
Do not rely on coreutils; if you need to use something from coreutils, you should write a shell function to do it. See tot and has, for example.
I'm fairly certain that you haven't read CONTRIBUTING.md - being that this uses ls, and you suggested both
cat
andgrep
in my PR.Do not rely on coreutils; if you need to use something from coreutils, you should write a shell function to do it. See tot and has, for example.
oh; i- yeah i have no excuse: i wasnt sure what coreutils were. i did read through the CONTRIBUTING.md, i guess just not enough.
but honestly i think that slackware is a distro with a package manager that just happens to be so backwards that it expects you to use ls
to view the packages that you have.
(and apparently for file -> packages and vice versa, as that was all i could find for it)
kept this as a separate branch so that it'd be easier to implement, i guess? includes the relocation of nix i had done in #19, and if either get done before the other, and i notice it: ill merge it to be with the latest lol