search

willemdj / erlsom

XML parser for Erlang
GNU Lesser General Public License v3.0
264 stars 103 forks source link

Type hierarchy lookup for types with no prefixes fixed. #67

Closed kape1395 closed 6 years ago

willemdj commented 6 years ago

Hi Karolis,

Can you give an example of a situation where this change is needed? So that I can test it.

Regards, Willem

kape1395 commented 6 years ago

I have no small example of it right now (my generated hrl is of 72kloc). I will try to add a test case next week for it. A minimal XSD/XML will be included. Do not merge this for now.

willemdj commented 6 years ago

Ok, great, thanks.

Op wo 1 aug. 2018 om 15:33 schreef Karolis Petrauskas < notifications@github.com>:

I have no small example of it right now (my generated hrl is of 72kloc). I will try to add a test case next week for it. A minimal XSD/XML will be included. Do not merge this for now.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/willemdj/erlsom/pull/67#issuecomment-409576110, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJjx6QSD8Qe2wzdIq6h2Qt9h7giICc6ks5uMa4xgaJpZM4Vp_O2 .

kape1395 commented 6 years ago

I added the test case and some comments. The problem appears only in the cases, when the default namespace is specified explicitly.

willemdj commented 6 years ago

Pulled, thanks.