search

willemdj / erlsom

XML parser for Erlang
GNU Lesser General Public License v3.0
264 stars 103 forks source link

The simpleType add final attribute #78

Closed cisiqo closed 3 years ago

cisiqo commented 3 years ago

The simpleType add final attribute

willemdj commented 3 years ago

Hi, sorry that I did not respond to this. Did you close it because you concluded that it was not correct or not needed? Or is it still relevant?

cisiqo commented 3 years ago

THANKS FOR YOUR REPLY. I'm a newbee, i use the function write_xsd_hrl_file/3 with the https://www.ecma-international.org/publications-and-standards/standards/ecma-376/ , have something wrong with final attribute. i push the first commit it worked for me. I think it correct.

Then found the function write hrl file repect some record and type, other erl file include it will throw an error. The second commit I haven't verified it, so I accidentally committed it.

So sorry.

willemdj commented 3 years ago

Ok, I merged your solution for the "final" attribute, thanks.

cisiqo commented 3 years ago

Awesome thank you so much.