search

willemdj / erlsom

XML parser for Erlang
GNU Lesser General Public License v3.0
265 stars 103 forks source link

Silence warnings and prepare for OTP26 #84

Closed filmor closed 2 years ago

filmor commented 2 years ago
filmor commented 2 years ago

@willemdj Could you have a look? OTP25 is coming closer :)

willemdj commented 2 years ago

Hello Benedikt,

Sorry that it is taking so long. Thank you for this, it seems quite fine and relevant. I’ll run my tests, and process it - I need to make up my mind whether it should be a new version… and remind myself how that works… I’ll try to do it soon.

Regards, Willem

Op 25 mrt. 2022 om 00:08 heeft Benedikt Reinartz @.***> het volgende geschreven:

 @willemdj Could you have a look? OTP25 is coming closer :)

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.

filmor commented 2 years ago

@willemdj Do you need help? With the release?

willemdj commented 2 years ago

I'm not sure I understand what you mean? I pulled the request. Do you need it to be a new release?

filmor commented 2 years ago

Well, yes, the published version 1.5 doesn't have these changes yet, which leads to warnings in our builds. Also, the change in processAnyNamespaces is in fact a bug fix.

willemdj commented 2 years ago

I published 1.5.1., with your changes and another pull request.

Op 15 okt. 2022 om 09:31 heeft Benedikt Reinartz @.***> het volgende geschreven:

 Well, yes, the published version 1.5 doesn't have these changes yet, which leads to warnings in our builds. Also, the change in processAnyNamespaces is in fact a bug fix.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.