search

willfarrell / alfred-github-workflow

Searching Github repos.
MIT License
209 stars 12 forks source link

`github password` fails if password has certain characters #2

Closed vitorgalvao closed 10 years ago

vitorgalvao commented 11 years ago

If the password has certain special characters, Alfred shows the default web search instead (those characters are probably confusing the script filter).

willfarrell commented 11 years ago

I tried a few special char and had no issue. Could you let me know which char is failing so I can add it to my testing. Thanks.

vitorgalvao commented 11 years ago

Pretty much every character that isn't a letter or number, like !"$%&/()=?*+^~-. # is a special case — it does not go back to the default search, but is also not shown on Alfred, while typing.

Quoting {query} makes it show the password in Alfred, but when running github test, it still says the password is missing.

willfarrell commented 11 years ago

Thank, retested after a few tweak and seems to work better. Please let me know.

vitorgalvao commented 11 years ago

1.1 solved the issue of it defaulting to search, but it still does not seem to correctly set the password, as github test still gives the same message (pressing ↩ to see documentation, as suggested, also does not work).

willfarrell commented 10 years ago

A bug reported help me find the bug related how the password is encoded. v1.4 has the new encoding update. Sorry it took so long.