Closed AlexisPPLIN closed 1 year ago
I suggest the change about ${}
but I think this is a necessary feature allowing us to keep our lifecycle but also allow user to override on build/compose the alpine version for those who needs different versions/latest.
What do you mean by ? :
I suggest the change about
${}
With this dockerfile update, user can build the image like this :
docker build --build-arg ALPINE_VERSION=latest -t autoheal .
What do you mean by ? :
I suggest the change about
${}
It should be:
ARG ALPINE_TAG
FROM alpine:${ALPINE_TAG:-3.18}
So user can pass ALPINE_TAG as build-arg (but whether he do not pass it, docker will use the default: 3.18).
AFAIK :
ARG ALPINE_TAG
FROM alpine:${ALPINE_TAG:-3.18}
Works the same as :
ARG ALPINE_TAG=3.18
FROM alpine:$ALPINE_TAG
As stated by Dockerfile reference : https://docs.docker.com/engine/reference/builder/#default-values
Dockerfile updates
ALPINE_VERSION
Argument (defaults to3.18
). This will allow to choose alpine version to create multiple builds as explained in #114(TODO) Github CI updates
With this update the github ci script could be updated to push multiples tags on every release.
Resolve #114