willfarrell / docker-autoheal

Monitor and restart unhealthy docker containers.
MIT License
1.31k stars 225 forks source link

Monitor only running containers and better writing of README.md #117

Closed christiantosta closed 7 months ago

christiantosta commented 1 year ago

Rebased and resubmitted parts of PR #115:

  1. Autoheal monitors all container by default. So added a adapted patch from boredazfcuk that enables the option (AUTOHEAL_ONLY_MONITOR_RUNNING) for monitor only running containers.

  2. Update the README.md for better writing and to include a docker-compose use example.

leleobhz commented 10 months ago

We should release a new tagged version as well

Agreed. Since no main breakage (Defaults still the same), I suggest 0.7.1.

That said, I'll review the code.

AlexisPPLIN commented 10 months ago

Agreed. Since no main breakage (Defaults still the same), I suggest 0.7.1.

I suggest 1.2.1 since the last tagged release on dockerhub is 1.2.0. I think vX.X.X was the old versionning scheme.

leleobhz commented 10 months ago

Agreed. Since no main breakage (Defaults still the same), I suggest 0.7.1.

I suggest 1.2.1 since the last tagged release on dockerhub is 1.2.0. I think vX.X.X was the old versionning scheme.

Indeed.

tracek commented 7 months ago

Thanks for that README, it's clearer than the original one. LGTM.

modem7 commented 7 months ago

@leleobhz - Thoughts?

leleobhz commented 7 months ago

LGTM