willghatch / emacs-on-parens

smartparens wrapper to fit with evil-normal-state
10 stars 2 forks source link

Fix package #1

Closed syohex closed 9 years ago

syohex commented 9 years ago
on-parens.el:175:1:Warning: Unused lexical variable `i'
on-parens.el:195:1:Warning: Unused lexical variable `i'
on-parens.el:216:1:Warning: Unused lexical variable `i'
on-parens.el:239:1:Warning: Unused lexical variable `i'
on-parens.el:248:1:Warning: Unused lexical variable `i'
on-parens.el:257:1:Warning: Unused lexical variable `i'
on-parens.el:265:1:Warning: Unused lexical variable `i'
on-parens.el:273:1:Warning: Unused lexical variable `i'
on-parens.el:286:1:Warning: Unused lexical variable `i'
on-parens.el:290:1:Warning: Unused lexical variable `i'

In end of data:
on-parens.el:336:1:Warning: the following functions are not known to be defined: equalp,
    on-parens-on-last-symbol-sexp?
willghatch commented 9 years ago

Hmm, well I'm not sure how to edit PRs with github's UI, so I just merged it on the command line. So while this will say it was rejected, it was actually accepted with modifications.

willghatch commented 9 years ago

Since you also sent a PR for my other emacs plugin (repeatable-motion), I'd like to ask out of curiosity if you use it and find it useful, as well as this one. I use them both and like them, but I don't really have any outside feedback to gauge other opinions.