search

willhains / guicebox

Automatically exported from code.google.com/p/guicebox
1 stars 2 forks source link

IllegalArgumentException in NonBlockingHeart #22

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Steps to reproduce:
1. Run any GuiceBox application with UdpFailover.

Expected result:
NonBlockingHeart should be able to receive heartbeats.

Actual result:
NonBlockingHeart gets an IllegalArgumentException from the 
ScheduledExecutorService due to the 
delay argument being 0.

Original issue reported on code.google.com by willhains on 28 Dec 2008 at 7:21

GoogleCodeExporter commented 9 years ago 
Temporary fix done in r119, by changing the delay argument to 1.

The permanent fix for this needs some thought - is it okay to have a 1ms delay 
between receive()s? The desired 
behaviour, which led to the IllegalArgumentException, is that the 
NonBlockingHeart is *always* listening for 
heartbeats. Introducing a 1ms delay could maybe miss some heartbeats...? Anyway 
it feels like a square peg, so 
I'm leaving this issue open for now.

Original comment by willhains on 28 Dec 2008 at 7:25

GoogleCodeExporter commented 9 years ago

Original comment by willhains on 13 Oct 2009 at 3:55

GoogleCodeExporter commented 9 years ago 
I can't produce a case where a heartbeat is missed, and even if it were, there 
is a retry tolerance anyway, so this 
is a non-issue. Closing.

Original comment by willhains on 13 Oct 2009 at 10:42