search

willhlaw / node-firestore-backup-restore

Google Firebase Firestore backup and restore tool
91 stars 24 forks source link

bugfix: geopoint data needs to be checked before doc ref #18

Closed andraus closed 6 years ago

andraus commented 6 years ago

Hello,

I fixed a bug that occurred when backing up geopoint values.

DocumentReference was being checked before geopoint and was failing due to an undefined type property. Checking geopoint first fixes the issue.

Thanks and regards,

willhlaw commented 6 years ago

Thanks for the fix. However, the changes should be made to the /lib/FirestoreDocument.js here around line 241 instead of the build file.

Once the change is made to the source file under /lib, then run yarn build or npm build to re-create the /build folder.

andraus commented 6 years ago

Thanks for the heads up. I just pushed a new commit for the correct file. The first commit, for the file under /build, isn't changed because yarn build produces exactly he same output as the change that I made manually, as it should.

willhlaw commented 6 years ago

Just published patch to npm as 1.3.1.