willi19 / swpp202301-compiler-team6

MIT License
0 stars 0 forks source link

Query on load2aload.cpp #20

Open germanium32 opened 1 year ago

germanium32 commented 1 year ago

In line 51 of load2aload.cpp, I found a slight problem in the code.

bool isSWPPIntrinsic(Instruction *I) {
  return isAloadSWPPIntrinsic(I) || isIncrDecrSWPPIntrinsic(I) ||
         isAssertSWPPIntrinsic(I);
}

There are four check functions, which checks Aload, Sum, Incr/Decr, Assert respectively, but in the last function that wraps up all the check function, there is only three of them. Since there are no sum instructions expected until the point of sprint 1, there will be no problems, but after adding the pass that I was assigned to in sprint 2, which is loop2sum, this may cause some problems.

goranmoomin commented 1 year ago

Yeah this is probably my mistake. Thanks for the note!